He was long on criticism [=he said many critical things] but short on useful advice.他提出了许多批评意见，但有用的建议却很少。